On 2023-05-22 22:52:40, Konrad Dybcio wrote: > > > On 22.05.2023 22:44, Marijn Suijten wrote: > > On 2023-05-22 13:30:20, Jessica Zhang wrote: > >> Currently, when compression is enabled, hdisplay is reduced via integer > >> division. This causes issues for modes where the original hdisplay is > >> not a multiple of 3. > >> > >> To fix this, use DIV_ROUND_UP to divide hdisplay. > >> > >> Reviewed-by: Marijn Suijten <marijn.suijten@xxxxxxxxxxxxxx> > >> Suggested-by: Marijn Suijten <marijn.suijten@xxxxxxxxxxxxxx> > > > > Nit: probably these should go in the opposite order. And if they're > > all supposed to be chronological, I think it is: > > > > Suggested-by: > > Fixes: > > Signed-off-by: > > Reviewed-by: > > > > But unsure if that's a hard requirement, or even correct at all. > > > > - Marijn > Or you can rely on b4 to pick that up if it comes from others The problem is that somewhat stupidly, b4 (trailers -u) puts them in the wrong (not chronological) order, so it's pretty much useless for this. Unless there's a required ordering specified somewhere in the docs, that is *not* chronological, and that b4 is abiding by? (that is my question above) - Marijn > > Konrad <snip>
