On 2023-05-19 00:40:03, Dmitry Baryshkov wrote: > > On 19/05/2023 00:39, Marijn Suijten wrote: > > On 2023-05-19 00:06:15, Dmitry Baryshkov wrote: > >> On 18/05/2023 22:14, Marijn Suijten wrote: > >>> On 2023-04-29 04:23:51, Dmitry Baryshkov wrote: > >>>> The src_blk declares a lame copy of main SSPP register space. It's > >>>> offset is always 0. It's length has been fixed to 0x150, while SSPP's > >>> > >>> It's -> its, twice. > >> > >> Ack > >> > >>> > >>> > >>> > >>>> length is now correct. Drop the src_blk and access SSPP registers > >>>> without additional subblock lookup. > >>> > >>> Note that the block code still calls `dpu_debugfs_create_regset32()` on > >>> "src_blk", do we want to rename that? > >>> > >> > >> I could not come up with a better debugfs file name, so I decided to > >> leave it as is. > > > > Just "blk" or "reg(s)"? This already sits in a dspp/%d subfolder so no > > need to repeat "dspp" at least. But also fine to leave it untouched for > > now. > > s/dspp/sspp/ ? Yes, sorry I've been looking at both blocks and keep mixing the names up. - Marijn
