Re: [PATCH v11 1/9] drm/display/dsc: Add flatness and initial scale value calculations

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 18/05/2023 01:58, Marijn Suijten wrote:
On 2023-05-17 14:32:42, Jessica Zhang wrote:


On 5/17/2023 2:13 PM, Marijn Suijten wrote:
On 2023-05-17 11:51:10, Jessica Zhang wrote:
Add helpers to calculate det_thresh_flatness and initial_scale_value as
these calculations are defined within the DSC spec.

Signed-off-by: Jessica Zhang <quic_jesszhan@xxxxxxxxxxx>

Was this r-b dropped because of changing the return types in v10->v11?

Hi Marijn,

Yea. I'm not sure what the protocol is for keeping/dropping r-b tags, so
dropped the r-b because I wasn't sure if the change counted as significant.

Yeah, seems to be standard practice on nontrivial changes but in this
case I left a review on a patch that already has my r-b, and you changed
exactly what I requested.  Probably fine either way.

Yes. Usually for trivial changes (e.g. whitespaces, renames, commit message changes) one can keep the RB/AB/TB tags.

--
With best wishes
Dmitry




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux