Am Mittwoch, dem 17.05.2023 um 08:02 -0500 schrieb Adam Ford: > On Wed, May 17, 2023 at 7:58 AM Lucas Stach <l.stach@xxxxxxxxxxxxxx> wrote: > > > > Am Montag, dem 15.05.2023 um 18:57 -0500 schrieb Adam Ford: > > > In order to support variable DPHY timings, it's necessary > > > to enable GENERIC_PHY_MIPI_DPHY so phy_mipi_dphy_get_default_config > > > can be used to determine the nominal values for a given resolution > > > and refresh rate. > > > > > I would just squash this one into the patch introducing the dependency. > > I thought Kconfig updates were supposed to be on their own. Is that > not correct? > I'm not aware of a general rule for this, but maybe I just missed it. Personally I would have added this to the patch introducing the dependency, but I'm also fine with keeping it as a separate patch. Regards, Lucas > adam > > > > Regards, > > Lucas > > > > > Signed-off-by: Adam Ford <aford173@xxxxxxxxx> > > > Tested-by: Frieder Schrempf <frieder.schrempf@xxxxxxxxxx> > > > Reviewed-by: Frieder Schrempf <frieder.schrempf@xxxxxxxxxx> > > > Tested-by: Chen-Yu Tsai <wenst@xxxxxxxxxxxx> > > > --- > > > drivers/gpu/drm/bridge/Kconfig | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig > > > index f076a09afac0..82c68b042444 100644 > > > --- a/drivers/gpu/drm/bridge/Kconfig > > > +++ b/drivers/gpu/drm/bridge/Kconfig > > > @@ -227,6 +227,7 @@ config DRM_SAMSUNG_DSIM > > > select DRM_KMS_HELPER > > > select DRM_MIPI_DSI > > > select DRM_PANEL_BRIDGE > > > + select GENERIC_PHY_MIPI_DPHY > > > help > > > The Samsung MIPI DSIM bridge controller driver. > > > This MIPI DSIM bridge can be found it on Exynos SoCs and > >