On 5/12/2023 5:39 PM, Dixit, Ashutosh wrote:
On Fri, 12 May 2023 16:56:03 -0700, Vinay Belgaumkar wrote:
Hi Vinay,
rps_boost debugfs shows host turbo related info. This is not valid
when SLPC is enabled.
A couple of thoughts about this. It appears people are know only about
rps_boost_info and don't know about guc_slpc_info? So:
a. Instead of hiding the rps_boost_info file do we need to print there
saying "SLPC is enabled, go look at guc_slpc_info"?
rps_boost_info has an eval() function which disables the interface when
RPS is OFF. This is indeed the case here, so shouldn't we just follow
that instead of trying to link the two?
b. Or, even just call guc_slpc_info_show from rps_boost_show (so the two
files will show the same SLPC information)?
slpc_info has a lot of other info like the SLPC state, not sure that
matches up with the rps_boost_info name.
Thanks,
Vinay.
Ashutosh
guc_slpc_info already shows the number of boosts. Add num_waiters there
as well and disable rps_boost when SLPC is enabled.
Bug: https://gitlab.freedesktop.org/drm/intel/-/issues/7632
Signed-off-by: Vinay Belgaumkar <vinay.belgaumkar@xxxxxxxxx>
