On 2023-05-11 09:22:47, Dmitry Baryshkov wrote: > On 11/05/2023 09:18, Marijn Suijten wrote: > > On 2023-05-11 07:26:28, Dmitry Baryshkov wrote: > >> On 11/05/2023 01:35, Jessica Zhang wrote: > >>> > >>> > >>> On 5/9/2023 11:29 PM, Marijn Suijten wrote: > >>>> On 2023-05-09 15:06:48, Jessica Zhang wrote: > >>>>> From: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> > >>>>> > >>>>> Add a helper setting config values which are typically constant across > >>>>> operating modes (table E-4 of the standard) and mux_word_size (which is > >>>>> a const according to 3.5.2). > >>>>> > >>>>> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> > >>>>> Signed-off-by: Jessica Zhang <quic_jesszhan@xxxxxxxxxxx> > >>>> > >>>> Same question about ordering. > >>> > >>> Hi Marijn, > >>> > >>> This patch was authored by Dmitry and originally part of his DRM DSC > >>> helpers series [1], but was removed from that series for mergeability > >>> reasons. > >>> > >>> Looking over the kernel documentation, the last Signed-off-by should be > >>> from the patch submitter [2], so I think my s-o-b tag should be at the > >>> bottom. > > > > That's true, but I also think the S-o-B at the top should match the > > From: author. > > I'd say, this is usual, but not the required order of tags. > > > > >>> As for the order in the previous patch, I can add a duplicate s-o-b > >>> before Dmitry's so that it reflects the history of the patch. > >> > >> I think this is an overkill. Instead you can drop my SOB from the patch > >> 1. We do not need this level of detail. > >> > >> For this patch the ordering of tags is correct. > > > > So indeed, that either means duplicating the S-o-B or dropping it > > entirely as we do not care that it was part of that series earlier. > > Dmitry will likely sign this off once again when picking the patches. > > Yes. > > I'd suggest the following tags: > > Patch 1 (Add flatness...): > From: Jessica > SOB: Jessica > > Patches 2 (add helper to set) and 3 (use DRM DSC helpers): > From: Dmitry > SOB: Dmitry > SOB: Jessica Both sound exactly right, as we do not care about that fact that the first patch was temporarily picked up by you in another series, and then dropped again. - Marijn
