Re: [PATCH] drm/xe: Make xe build dependent on STAGING.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, May 09, 2023 at 11:10:08AM -0400, Rodrigo Vivi wrote:
As documented in drivers/staging/Kconfig:

STAGING means "that these drivers are under heavy development" and
"may contain userspace interfaces that most likely will be changed
in the near future."

As explained in Documentation/gpu/rfc/xe.rst:

"
Xe driver will be protected with both STAGING Kconfig and force_probe.
Changes in the uAPI are expected while the driver is behind these
protections. STAGING will be removed when the driver uAPI gets to a
mature state where we can guarantee the ‘no regression’ rule.
Then force_probe will be lifted only for future platforms that will be
productized with Xe driver, but not with i915.
"

Cc: Mauro Carvalho Chehab <mchehab@xxxxxxxxxx>
Cc: Lucas De Marchi <lucas.demarchi@xxxxxxxxx>
Cc: Radoslaw Szwichtenberg <radoslaw.szwichtenberg@xxxxxxxxx>
Cc: Maciej Ramotowski <maciej.ramotowski@xxxxxxxxx>
Cc: Kamil Konieczny <kamil.konieczny@xxxxxxxxxxxxxxx>
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@xxxxxxxxx>

I agree with the idea, but I was expecting a few more hits:

	$ git grep "\bSTAGING\b" -- '*Kconfig'
	drivers/gpu/drm/nouveau/Kconfig:        depends on STAGING
	drivers/gpu/drm/tegra/Kconfig:  depends on STAGING
	drivers/staging/Kconfig:menuconfig STAGING
	drivers/staging/Kconfig:if STAGING
	drivers/staging/Kconfig:endif # STAGING
	drivers/staging/vme_user/Kconfig:       depends on STAGING && PCI
	drivers/staging/vme_user/Kconfig:       depends on STAGING && VME_BUS

Are we doing something wrong here? Documentation/process/2.Process.rst
talks about drivers under staging/ directory rather than drivers
depending on CONFIG_STAGING.

Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
Cc: linux-staging@xxxxxxxxxxxxxxx
Cc: dri-devel@xxxxxxxxxxxxxxxxxxxxx

Lucas De Marchi

---
drivers/gpu/drm/xe/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/xe/Kconfig b/drivers/gpu/drm/xe/Kconfig
index f6f3b491d162..1a410edd38e4 100644
--- a/drivers/gpu/drm/xe/Kconfig
+++ b/drivers/gpu/drm/xe/Kconfig
@@ -2,6 +2,7 @@
config DRM_XE
	tristate "Intel Xe Graphics"
	depends on DRM && PCI && MMU
+	depends on STAGING
	select INTERVAL_TREE
	# we need shmfs for the swappable backing store, and in particular
	# the shmem_readpage() which depends upon tmpfs
--
2.39.2




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux