Re: [RFC PATCH 03/40] drm/amd/display: introduce Steam Deck color features to AMD display driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 05/08, Harry Wentland wrote:
> On 4/23/23 10:10, Melissa Wen wrote:
> > We are enabling a large set of color calibration features to enhance KMS
> > color mgmt but these properties are specific of AMD display HW, and
> > cannot be provided by other vendors. Therefore, set a config option to
> > enable AMD driver-private properties used on Steam Deck color mgmt
> > pipeline.
> > 
> > Co-developed-by: Joshua Ashton <joshua@xxxxxxxxx>
> > Signed-off-by: Joshua Ashton <joshua@xxxxxxxxx>
> > Signed-off-by: Melissa Wen <mwen@xxxxxxxxxx>
> > ---
> >  drivers/gpu/drm/amd/display/Kconfig | 6 ++++++
> >  1 file changed, 6 insertions(+)
> > 
> > diff --git a/drivers/gpu/drm/amd/display/Kconfig b/drivers/gpu/drm/amd/display/Kconfig
> > index 06b438217c61..c45a8deb1098 100644
> > --- a/drivers/gpu/drm/amd/display/Kconfig
> > +++ b/drivers/gpu/drm/amd/display/Kconfig
> > @@ -53,5 +53,11 @@ config DRM_AMD_SECURE_DISPLAY
> >              of crc of specific region via debugfs.
> >              Cooperate with specific DMCU FW.
> >  
> > +config STEAM_DECK
> > +	bool "Enable color calibration features for Steam Deck"
> > +	depends on DRM_AMD_DC
> > +	help
> > +	  Choose this option if you want to use AMDGPU features for broader
> > +	  color management support on Steam Deck.
> >  
> 
> If we can drop this (i.e. don't offer a CONFIG_ option to allow enablement of
> the uAPI, but build with -DCONFIG_STEAM_DECK) it would go a long way to keep
> us from requiring to support this forever.

I see, I'll follow this path. Still on that, I've changed
CONFIG_STEAM_DECK (too generic) to CONFIG_DRM_AMD_COLOR_STEAMDECK.
Does it sound better?

Thanks,

Melissa

> 
> Harry
> 
> >  endmenu
> 
> 

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux