On Tue, 9 May 2023 at 10:00, Marijn Suijten <marijn.suijten@xxxxxxxxxxxxxx> wrote: > > On 2023-05-09 02:08:52, Dmitry Baryshkov wrote: > > On 09/05/2023 00:46, Jessica Zhang wrote: > > > > > > > > > On 5/7/2023 9:00 AM, Marijn Suijten wrote: > > >> On 2023-05-05 14:23:50, Jessica Zhang wrote: > > >>> Add DATA_COMPRESS feature flag to DPU INTF block. > > >>> > > >>> In DPU 7.x and later, DSC/DCE enablement registers have been moved from > > >>> PINGPONG to INTF. > > >>> > > >>> As core_rev (and related macros) was removed from the dpu_kms struct, > > >>> the > > >>> most straightforward way to indicate the presence of this register > > >>> would be > > >>> to have a feature flag. > > >> > > >> Irrelevant. Even though core_rev was still in mainline until recently, > > >> we always hardcoded the features in the catalog and only used core_rev > > >> to select a dpu_mdss_cfg catalog entry. There is no "if version >= X > > >> then enable feature Y" logic, this manually-enabled feature flag is the > > >> only, correct way to do it. > > > > > > Hi Marijn, > > > > > > Understood. FWIW, if we do find more register bit-level differences > > > between HW versions in the future, it might make more sense to keep the > > > HW catalog small and bring core_rev back, rather than keep adding these > > > kinds of small differences to caps. > > > > Let's see how it goes. Abhinav suggested that there might be feature > > differences inside the DPU generations (and even inside the single DPU > > major/minor combo). So I'm not sure what core_rev will bring us. > > > > Let's land the platforms which are ready (or if there is anything close > > to be submitted). > > You mean waiting for catalog changes on the list specifically, so the > DSC series as well as SM6350/SM6375? I do intend to send SM6125 now > that the INTF TE series (required for it, as well as for SM63**) seems > to be generally accepted, but have been quite busy with the DSC series > on the list as we're now unblocking many Xperia's to finally have > display! Yes, please send it, as you find time. No time pressure. > > The catalog addition is "pretty much ready", let me know if you'd like > it to be sent in prior to your cleanup. -- With best wishes Dmitry
