Re: [PATCH 2/2] drm/panel: sharp-ls043t1le01: drop dummy functions and data fields

[Neil Armstrong <neil.armstrong@xxxxxxxxxx>]

On 07/05/2023 19:26, Dmitry Baryshkov wrote:
> Drop sharp_nt_panel_disable() and sharp_nt_panel_enable(), which bear no
> useful code. Also drop sharp_nt_panel::enable and sharp_nt_panel::mode
> fields which also provide no use now.
>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
> ---
>   .../gpu/drm/panel/panel-sharp-ls043t1le01.c   | 32 -------------------
>   1 file changed, 32 deletions(-)
>
> diff --git a/drivers/gpu/drm/panel/panel-sharp-ls043t1le01.c b/drivers/gpu/drm/panel/panel-sharp-ls043t1le01.c
> index ef148504cf24..855e64444daa 100644
> --- a/drivers/gpu/drm/panel/panel-sharp-ls043t1le01.c
> +++ b/drivers/gpu/drm/panel/panel-sharp-ls043t1le01.c
> @@ -28,9 +28,6 @@ struct sharp_nt_panel {
>   	struct gpio_desc *reset_gpio;
>   
>   	bool prepared;
> -	bool enabled;
> -
> -	const struct drm_display_mode *mode;
>   };
>   
>   static inline struct sharp_nt_panel *to_sharp_nt_panel(struct drm_panel *panel)
> @@ -97,19 +94,6 @@ static int sharp_nt_panel_off(struct sharp_nt_panel *sharp_nt)
>   	return 0;
>   }
>   
> -
> -static int sharp_nt_panel_disable(struct drm_panel *panel)
> -{
> -	struct sharp_nt_panel *sharp_nt = to_sharp_nt_panel(panel);
> -
> -	if (!sharp_nt->enabled)
> -		return 0;
> -
> -	sharp_nt->enabled = false;
> -
> -	return 0;
> -}
> -
>   static int sharp_nt_panel_unprepare(struct drm_panel *panel)
>   {
>   	struct sharp_nt_panel *sharp_nt = to_sharp_nt_panel(panel);
> @@ -179,18 +163,6 @@ static int sharp_nt_panel_prepare(struct drm_panel *panel)
>   	return ret;
>   }
>   
> -static int sharp_nt_panel_enable(struct drm_panel *panel)
> -{
> -	struct sharp_nt_panel *sharp_nt = to_sharp_nt_panel(panel);
> -
> -	if (sharp_nt->enabled)
> -		return 0;
> -
> -	sharp_nt->enabled = true;
> -
> -	return 0;
> -}
> -
>   static const struct drm_display_mode default_mode = {
>   	.clock = (540 + 48 + 32 + 80) * (960 + 3 + 10 + 15) * 60 / 1000,
>   	.hdisplay = 540,
> @@ -227,10 +199,8 @@ static int sharp_nt_panel_get_modes(struct drm_panel *panel,
>   }
>   
>   static const struct drm_panel_funcs sharp_nt_panel_funcs = {
> -	.disable = sharp_nt_panel_disable,
>   	.unprepare = sharp_nt_panel_unprepare,
>   	.prepare = sharp_nt_panel_prepare,
> -	.enable = sharp_nt_panel_enable,
>   	.get_modes = sharp_nt_panel_get_modes,
>   };
>   
> @@ -239,8 +209,6 @@ static int sharp_nt_panel_add(struct sharp_nt_panel *sharp_nt)
>   	struct device *dev = &sharp_nt->dsi->dev;
>   	int ret;
>   
> -	sharp_nt->mode = &default_mode;
> -
>   	sharp_nt->supply = devm_regulator_get(dev, "avdd");
>   	if (IS_ERR(sharp_nt->supply))
>   		return PTR_ERR(sharp_nt->supply);

Reviewed-by: Neil Armstrong <neil.armstrong@xxxxxxxxxx>