Hello Neil, On Mon, Mar 20, 2023 at 11:54:12AM +0100, Neil Armstrong wrote: > On Sat, 18 Mar 2023 20:07:45 +0100, Uwe Kleine-König wrote: > > this series adapts the platform drivers below drivers/gpu/drm/bridge to use the > > .remove_new() callback. Compared to the traditional .remove() callback > > .remove_new() returns no value. This is a good thing because the driver core > > doesn't (and cannot) cope for errors during remove. The only effect of a > > non-zero return value in .remove() is that the driver core emits a warning. The > > device is removed anyhow and an early return from .remove() usually yields a > > resource leak. > > > > [...] > > Thanks, Applied to https://anongit.freedesktop.org/git/drm/drm-misc.git (drm-misc-next) > > [02/19] drm/bridge: cdns-dsi: Convert to platform remove callback returning void > https://cgit.freedesktop.org/drm/drm-misc/commit/?id=d5701d8f5210f8c70ffd1b51283b2373573e7b5a > [04/19] drm/bridge: display-connector: Convert to platform remove callback returning void > https://cgit.freedesktop.org/drm/drm-misc/commit/?id=d1837136d184dda0585a687c614a9117cc87ad27 > [05/19] drm/bridge: fsl-ldb: Convert to platform remove callback returning void > https://cgit.freedesktop.org/drm/drm-misc/commit/?id=be5c6b177229c5cb40f3fef785250afbfd669175 > [...] I wonder what made you skip patches #1 and #3. I got some feedback by Laurent for patch #1. In the end it was Laurent's "I don't have a string preference here." vs me thinking that the patch is good as is. Was that the reason to skip it? Patch #3 depends on patch #1. Would it help to resent? Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ |
Attachment:
signature.asc
Description: PGP signature
