On 2023-04-28 16:03:54, Dmitry Baryshkov wrote: <snip> > >> + .qseed_type = DPU_SSPP_SCALER_QSEED4, > > > > I thought it was QSEED3LITE, but doesn't really matter as both are > > handled similarly. It'll anyway change when I resubmit: > > If I understood correctly, we mixed two things: hw stuff and the > userspace library. QSEEDv2 was a hardware scaler. "qseedv3/v3lite/v4" > are software library names that are used with the scalers newer than > QSEED2. From the driver point we can ignore that and use scaler's hw > version (which mostly but not always corresponds to the 3/3lite/4). If I remember correctly, that matches the register changes we intended to do in the patch below. This was only available starting at qseedv3. One of the replies in that thread clarifies which register value is used on what hardware, and that is what downstream switches on. I'll try and respin it once we're through the DSC series. - Marijn > > https://lore.kernel.org/linux-arm-msm/20230215-sspp-scaler-version-v1-0-416b1500b85b@xxxxxxxxxxxxxx/T/#u > > > > which should hardcode the register value directly, making this field > > superfluous. <snip>
