On 2023-05-08 10:36:09, Konrad Dybcio wrote: <snip> > > Depending on who lands first, this flag should be split. > I'll adapt my patches. Jessica, no changes required on your side. Looks like no split is needed after moving HCTL to SC7180. Your SM6375 series can use SC7180 instead of SC7280 now and everything will be right without a change here. > > I still see value in inlining and removing these defines, though that > > brings a host of other complexity. > right, we should totally do it after we settle down from the patch > flurry But we just got a nice velocity, I'd rather keep going :) - we can totally address these cleanups somewhere along the line though. - Marijn