May 7, 2023 at 7:26 PM, "Uwe Kleine-König" <u.kleine-koenig@xxxxxxxxxxxxxx mailto:u.kleine-koenig@xxxxxxxxxxxxxx?to=%22Uwe%20Kleine-K%C3%B6nig%22%20%3Cu.kleine-koenig%40pengutronix.de%3E > wrote: > > The .remove() callback for a platform driver returns an int which makes > many driver authors wrongly assume it's possible to do error handling by > returning an error code. However the value returned is (mostly) ignored > and this typically results in resource leaks. To improve here there is a > quest to make the remove callback return void. In the first step of this > quest all drivers are converted to .remove_new() which already returns > void. > > Trivially convert this driver from always returning zero in the remove > callback to the void returning variant. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx> Reviewed-by: Jyri Sarha <jyri.sarha@xxxxxx> > --- > drivers/gpu/drm/tilcdc/tilcdc_panel.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/tilcdc/tilcdc_panel.c b/drivers/gpu/drm/tilcdc/tilcdc_panel.c > index 2729e16bc053..9aefd010acde 100644 > --- a/drivers/gpu/drm/tilcdc/tilcdc_panel.c > +++ b/drivers/gpu/drm/tilcdc/tilcdc_panel.c > @@ -374,7 +374,7 @@ static int panel_probe(struct platform_device *pdev) > return ret; > } > > -static int panel_remove(struct platform_device *pdev) > +static void panel_remove(struct platform_device *pdev) > { > struct tilcdc_module *mod = dev_get_platdata(&pdev->dev); > struct panel_module *panel_mod = to_panel_module(mod); > @@ -387,8 +387,6 @@ static int panel_remove(struct platform_device *pdev) > > tilcdc_module_cleanup(mod); > kfree(panel_mod->info); > - > - return 0; > } > > static const struct of_device_id panel_of_match[] = { > @@ -398,7 +396,7 @@ static const struct of_device_id panel_of_match[] = { > > static struct platform_driver panel_driver = { > .probe = panel_probe, > - .remove = panel_remove, > + .remove_new = panel_remove, > .driver = { > .name = "tilcdc-panel", > .of_match_table = panel_of_match, > -- > 2.39.2 >
