On 08-05-23, 10:24, Matthias Brugger wrote: > > > On 08/05/2023 09:48, Vinod Koul wrote: > > On 05-05-23, 17:37, Matthias Brugger wrote: > > > > > > > > > On 05/05/2023 11:28, Vinod Koul wrote: > > > > On 14-04-23, 08:22, Tom Rix wrote: > > > > > clang reports > > > > > drivers/phy/mediatek/phy-mtk-hdmi-mt8195.c:298:6: error: variable > > > > > 'ret' is uninitialized when used here [-Werror,-Wuninitialized] > > > > > if (ret) > > > > > ^~~ > > > > > ret should have been set by the preceding call to mtk_hdmi_pll_set_hw. > > > > > > > > I have applied "phy: mediatek: hdmi: mt8195: fix uninitialized variable > > > > usage in pll_calc" > > > > > > Thanks Vinod, that was on my list for today as well. I was a bit puzzled > > > because you took the patch that added it, but I wasn't sure if you would > > > take the fix. How do you want to handle things like this in the future? > > > > Fixes should be sent as Fixes patch > > > > I'm not sure what do you mean. Patch subject includes the word fix and the > patch has a fixes tag. What was missing here? > > Does this mean you will take fixes for this driver in the future or do you > want me to take care of them? Yes I would take the fixes as well for the drivers -- ~Vinod
