Hi Uwe,
Thank you for the patch.
On Sun, May 07, 2023 at 06:25:31PM +0200, Uwe Kleine-König wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is (mostly) ignored
> and this typically results in resource leaks. To improve here there is a
> quest to make the remove callback return void. In the first step of this
> quest all drivers are converted to .remove_new() which already returns
> void.
>
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> ---
> drivers/gpu/drm/bridge/display-connector.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/display-connector.c b/drivers/gpu/drm/bridge/display-connector.c
> index 9a12449ad7b8..fbb3e102c02f 100644
> --- a/drivers/gpu/drm/bridge/display-connector.c
> +++ b/drivers/gpu/drm/bridge/display-connector.c
> @@ -382,7 +382,7 @@ static int display_connector_probe(struct platform_device *pdev)
> return 0;
> }
>
> -static int display_connector_remove(struct platform_device *pdev)
> +static void display_connector_remove(struct platform_device *pdev)
> {
> struct display_connector *conn = platform_get_drvdata(pdev);
>
> @@ -396,8 +396,6 @@ static int display_connector_remove(struct platform_device *pdev)
>
> if (!IS_ERR(conn->bridge.ddc))
> i2c_put_adapter(conn->bridge.ddc);
> -
> - return 0;
> }
>
> static const struct of_device_id display_connector_match[] = {
> @@ -426,7 +424,7 @@ MODULE_DEVICE_TABLE(of, display_connector_match);
>
> static struct platform_driver display_connector_driver = {
> .probe = display_connector_probe,
> - .remove = display_connector_remove,
> + .remove_new = display_connector_remove,
> .driver = {
> .name = "display-connector",
> .of_match_table = display_connector_match,
> --
> 2.39.2
>
--
Regards,
Laurent Pinchart
