Hi Uwe,
Thank you for the patch.
On Sun, May 07, 2023 at 06:25:34PM +0200, Uwe Kleine-König wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is (mostly) ignored
> and this typically results in resource leaks. To improve here there is a
> quest to make the remove callback return void. In the first step of this
> quest all drivers are converted to .remove_new() which already returns
> void.
>
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> ---
> drivers/gpu/drm/bridge/lvds-codec.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/lvds-codec.c b/drivers/gpu/drm/bridge/lvds-codec.c
> index 39e7004de720..67368f23d4aa 100644
> --- a/drivers/gpu/drm/bridge/lvds-codec.c
> +++ b/drivers/gpu/drm/bridge/lvds-codec.c
> @@ -215,13 +215,11 @@ static int lvds_codec_probe(struct platform_device *pdev)
> return 0;
> }
>
> -static int lvds_codec_remove(struct platform_device *pdev)
> +static void lvds_codec_remove(struct platform_device *pdev)
> {
> struct lvds_codec *lvds_codec = platform_get_drvdata(pdev);
>
> drm_bridge_remove(&lvds_codec->bridge);
> -
> - return 0;
> }
>
> static const struct of_device_id lvds_codec_match[] = {
> @@ -243,7 +241,7 @@ MODULE_DEVICE_TABLE(of, lvds_codec_match);
>
> static struct platform_driver lvds_codec_driver = {
> .probe = lvds_codec_probe,
> - .remove = lvds_codec_remove,
> + .remove_new = lvds_codec_remove,
> .driver = {
> .name = "lvds-codec",
> .of_match_table = lvds_codec_match,
> --
> 2.39.2
>
--
Regards,
Laurent Pinchart
