Re: [PATCH] drm/udl: delete dead code

[Takashi Iwai <tiwai@xxxxxxx>]

On Tue, 02 May 2023 14:59:56 +0200,
Dan Carpenter wrote:
> 
> The "unode" pointer cannot be NULL here and checking for it causes
> Smatch warnings:
> 
>    drivers/gpu/drm/udl/udl_main.c:259 udl_get_urb_locked()
>    warn: can 'unode' even be NULL?
> 
> Fortunately, it's just harmless dead code which can be removed.  It's
> left over from commit c5c354a3a472 ("drm/udl: Fix inconsistent urbs.count
> value during udl_free_urb_list()").
> 
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>

Reviewed-by: Takashi Iwai <tiwai@xxxxxxx>


thanks,

Takashi