Hi Am 26.04.23 um 17:21 schrieb Geert Uytterhoeven:
Hi Thomas, On Wed, Apr 26, 2023 at 5:06 PM Thomas Zimmermann <tzimmermann@xxxxxxx> wrote:Am 26.04.23 um 17:01 schrieb Geert Uytterhoeven:On Tue, Apr 25, 2023 at 4:28 PM Thomas Zimmermann <tzimmermann@xxxxxxx> wrote:Move the existing CFB read and write code for I/O memory into the new helpers fb_cfb_read() and fb_cfb_write(). Make them the default fp_ops. No functional changes. Signed-off-by: Thomas Zimmermann <tzimmermann@xxxxxxx> --- drivers/video/fbdev/core/Makefile | 2 +- drivers/video/fbdev/core/fb_cfb_fops.c | 126 +++++++++++++++++++++++++ drivers/video/fbdev/core/fbmem.c | 113 +--------------------- include/linux/fb.h | 10 ++ 4 files changed, 139 insertions(+), 112 deletions(-) create mode 100644 drivers/video/fbdev/core/fb_cfb_fops.cWhile the general idea is fine, please do not call any of this "cfb", as it is not related to chunky color frame buffer formats. All of these operate on the raw frame buffer contents.Shall I call it fb_raw_() or fb_io_()?Given fb_memcpy_fromfb() is mapped to memcpy_fromio() on most architectures, I'd go for fb_io_*().
Ok, makes sense.
CFB is used by the drawing helpers, which are usually used together with this code. Hence the current naming.That's because your drawing helpers operate (only) on chunky color frame buffer formats ;-)
Should we rename the CFB drawing functions to fb_io_ then? AFAICT they are the same algorithms as in the fb_sys_ functions; just with I/O memory.
Best regards Thomas
Gr{oetje,eeting}s,
Geert
-- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstrasse 146, 90461 Nuernberg, Germany GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman HRB 36809 (AG Nuernberg)
Attachment:
OpenPGP_signature
Description: OpenPGP digital signature
