Hi, On Sun, 23 Apr 2023 10:53:00 -0400, Tom Rix wrote: > smatch has several simailar warnings to > drivers/gpu/drm/meson/meson_venc.c:189:28: warning: symbol > 'meson_hdmi_enci_mode_480i' was not declared. Should it be static? > > These variables are only used in their defining file so should be static > > > [...] Thanks, Applied to https://anongit.freedesktop.org/git/drm/drm-misc.git (drm-misc-next) [1/1] drm/meson: set variables meson_hdmi_* storage-class-specifier to static https://cgit.freedesktop.org/drm/drm-misc/commit/?id=4b733b2c38b7c9304bbb92cf88f1b23f43ca575d -- Neil
