Il 12/09/22 03:29, Jason-JH.Lin ha scritto:
Since the gamma_set_common() function for previous SoC,
such as mt8173 and mt8183, is designed for 9bit-to-10bit
conversion.
mt8195 is using 10bit-to-12bit conversion, which is
not compatible with the previous function.
Thus, need to update the function to fit the need of mt8195.
Hello,
can you please respin and fix this series on the latest linux-next?
Besides, please test it carefully: as far as I can see, GNOME Night Light
(or others) are not working on MT8195 (color temperature/ccorr).
As for gamma itself, that's not working either; you can test it with a tool
that will create a color profile by applying a new VCGT table, please look
at [1] if you need tools.
We can confirm that color correction works on at least MT8192 (colord), so
it's MT8195 at fault.
[1]: https://github.com/zb3/gnome-gamma-tool
Regards,
Angelo
---
Change in RESEND v3:
Fix build warning
drivers/gpu/drm/mediatek/mtk_disp_gamma.c:59:14: warning: no previous prototype for 'mtk_gamma_get_size' [-Wmissing-prototypes]
Change in v3:
1. separate 1 dt-binding patch to 2 patches, 1 is for modifying
multiple items list to one and 1 is for moving mt8195 compatible.
2. redefine variables to reduce memory usage.
3. delete unused symbols.
4. separate 1 drm/mediatek patch to 6 patches.
5. rebase on tag 'next-20220909'
Jason-JH.Lin (5):
drm/mediatek: Adjust mtk_drm_gamma_set_common parameters
drm/mediatek: Add gamma support different lut_size for other SoC
drm/mediatek: Add gamma support different lut_bits for other SoC
drm/mediatek: Add gamma support different bank_size for other SoC
drm/mediatek: Add clear RELAY_MODE bit to set gamma
zheng-yan.chen (4):
dt-bindings: mediatek: modify item formatting for gamma
dt-bindings: mediatek: Add gamma compatible for mt8195
drm/mediatek: Add gamma lut support for mt8195
arm64: dts: Modify gamma compatible for mt8195
.../display/mediatek/mediatek,gamma.yaml | 8 +-
arch/arm64/boot/dts/mediatek/mt8195.dtsi | 2 +-
drivers/gpu/drm/mediatek/mtk_disp_aal.c | 2 +-
drivers/gpu/drm/mediatek/mtk_disp_drv.h | 3 +-
drivers/gpu/drm/mediatek/mtk_disp_gamma.c | 115 ++++++++++++++----
drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 4 +-
drivers/gpu/drm/mediatek/mtk_drm_crtc.h | 1 -
drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h | 9 ++
8 files changed, 109 insertions(+), 35 deletions(-)
