On 2023-04-25 15:37:44, Abhinav Kumar wrote: > > > On 4/25/2023 3:15 PM, Marijn Suijten wrote: > > On 2023-04-25 14:55:56, Abhinav Kumar wrote: > > <snip> > >>> I'll see whether I can include these fixes before sending v3 (got all > >>> the other changes in and am all-ready to send it): is there any other > >>> SoC you're seeing this issue on? > >>> > >> > >> Thats alright, you can have it in a separate series not v3 of this one. > >> > >> I am picking up the fixes from this one now. > >> > >> I will update the other SOCs on IRC or even better i will take up this > >> cleanup. > > > > I already have the fix patch in my tree that is compatible with the > > other patches, and will send those in a minute. All DPU >= 7.0.0 seems > > to be affected, both SM8350 and SM8450 need to use the SC7280 sblk with > > DITHER V2 at 0xe0 (SM8250 is still V1). I believe SC8280XP should also > > be updated but do not have access to DTS: where can I find that (what is > > its codename again?) or can you otherwise confirm this for me? > > > > Sure, I can wait another day too. Dont want to rush you too much for this. Thank you. There are even more Fixes: patches now as well as some small wording cleanups. > 8280xp still has dither at 0xe0 and yes its version is V2. Thanks! Added that info now. Is the PP blk still length 0xd4? > 8280xp's DTS is not located in the techpack. Its a different tree. A tree that's... not public? - Marijn