Thomas Zimmermann <tzimmermann@xxxxxxx> writes: Hello Thomas, > Always return the number of bytes read or written within the > framebuffer. Only return an errno code if framebuffer memory > was not touched. This is the semantics required by POSIX and > makes fb_read() and fb_write() compatible with IGT tests. [1] > > This bug has been fixed for fb_write() long ago by > commit 6a2a88668e90 ("[PATCH] fbdev: Fix return error of > fb_write"). The code in fb_read() and the corresponding fb_sys_() > helpers was forgotten. > > Signed-off-by: Thomas Zimmermann <tzimmermann@xxxxxxx> > Link: https://gitlab.freedesktop.org/drm/igt-gpu-tools/-/blob/master/tests/fbdev.c # 1 > --- The patch looks good to me and indeed the correct semantics AFAICT. Reviewed-by: Javier Martinez Canillas <javierm@xxxxxxxxxx> -- Best regards, Javier Martinez Canillas Core Platforms Red Hat