On 21/04/2023 18:51, Doug Anderson wrote: >>> ...and, again, it matches the order that I thought was right. In other >>> words, the patch file generated says: >>> >>>> Signed-off-by: Richard Leitner <richard.leitner@xxxxxxxxxxx> >>>> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> >> >> We talk about `b4 trailers`, because the tag is applied by the >> submitter, not by the maintainer. >> >>> >>> Did I get something wrong in the above? >> >> Your `b4 am` will of course put the tag later, because it is you who >> applies the tag. > > Ah, got it. So I guess from the perspective of "b4" every time the > author modifies a patch (like adding new tags to it) then it's a new > application of Signed-off-by and thus the old Signed-off-by is removed > from the top and a new one is added below all the tags that have been > received. Thus if b4 grabs all the tags off the mailing list for > applying it ends up in a different order than if it grabs all the tags > off the mailing list for sending a new version. > > OK, I can understand that perspective. I'll keep it in mind. Yeah. I actually agree with your point that submitter's SoB should always be the last one, but I agree more with using process via standardized tools. IOW, since I cannot change in this matter b4, I need to agree with it. :) Best regards, Krzysztof
