On Fri, Apr 21, 2023 at 10:07:28AM -0400, Rodrigo Vivi wrote: > On Fri, Apr 21, 2023 at 03:46:54PM +0200, Andi Shyti wrote: > > In the process of renaming all instances of 'dev_priv' to 'i915', > > start using 'i915' within the 'drm_i915_file_private' structure. > > The patch looks good but the commit message seems off to me... Will rephrase. > One thing we need to take care with mass conversions of dev_priv > to i915 is to ensure we are not converting the implicit declarations, > since we want to kill that. But on a quick glance it looks fine. > > Did you generated this with full s/dev_priv/i915 in i915_drv.h? Yes, I did such swap in i915_drv.h but I checked each line not to break anything. In this file it's OK to do a /dev_priv/i915/ change. It will be different with i915_irq.h where dev_priv is embedded in the define. I there is anything off it wouldn't have compiled and anyway, CI will warn. Thanks, Rodrigo! Andi
