On 20/04/2023 12:39, Andi Shyti wrote:
Hi Fei,To comply with the design that buffer objects shall have immutable cache setting through out their life cycle, {set, get}_caching ioctl's are no longer supported from MTL onward. With that change caching policy can only be set at object creation time. The current code applies a default (platform dependent) cache setting for all objects. However this is not optimal for performance tuning. The patch extends the existing gem_create uAPI to let user set PAT index for the object at creation time. The new extension is platform independent, so UMD's can switch to using this extension for older platforms as well, while {set, get}_caching are still supported on these legacy paltforms for compatibility reason. Cc: Chris Wilson <chris.p.wilson@xxxxxxxxxxxxxxx> Cc: Matt Roper <matthew.d.roper@xxxxxxxxx> Cc: Andi Shyti <andi.shyti@xxxxxxxxxxxxxxx> Signed-off-by: Fei Yang <fei.yang@xxxxxxxxx> Reviewed-by: Andi Shyti <andi.shyti@xxxxxxxxxxxxxxx>because this is an API change, we need some more information here. First of all you need to CC the userspace guys that have been working on top of your series and get their ack's.
Yes, and a link to a Mesa merge request which uses the uapi should be included.
IGTs should be ready to before we can merge. I glanced over igt-dev but did not spot anything.
Regards, Tvrtko
I also believe that this series has also been tested on a separate repository, would you link it in the commit message? Thanks, Andi
