Re: [PATCH v2 1/2] drm/radeon: Fix integer overflow in radeon_cs_parser_init

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Am 19.04.23 um 10:57 schrieb hackyzh002:
The type of size is unsigned, if size is 0x40000000, there will be an
integer overflow, size will be zero after size *= sizeof(uint32_t),
will cause uninitialized memory to be referenced later

Signed-off-by: hackyzh002 <hackyzh002@xxxxxxxxx>
---
  drivers/gpu/drm/radeon/radeon_cs.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/radeon/radeon_cs.c b/drivers/gpu/drm/radeon/radeon_cs.c
index 46a27ebf4..8e12b406e 100644
--- a/drivers/gpu/drm/radeon/radeon_cs.c
+++ b/drivers/gpu/drm/radeon/radeon_cs.c
@@ -270,7 +270,7 @@ int radeon_cs_parser_init(struct radeon_cs_parser *p, void *data)
  {
  	struct drm_radeon_cs *cs = data;
  	uint64_t *chunk_array_ptr;
-	unsigned size, i;
+	u64 size, i;

Ok, once more: Please only change the type of the "size" variable" and not the type of "i".

Otherwise the patch looks good to me,
Christian.

  	u32 ring = RADEON_CS_RING_GFX;
  	s32 priority = 0;




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux