On 2023-04-17 18:54:18, Abhinav Kumar wrote: > > On 4/17/2023 4:14 PM, Marijn Suijten wrote: > > Some of these members were initialized while never read, while others > > were not even assigned any value at all. Drop them to save some space, > > and above all confusion when looking at these members. > > > > Fixes: 25fdd5933e4c ("drm/msm: Add SDM845 DPU support") > > Fixes: 84a33d0fd921 ("drm/msm/dpu: add dpu_hw_wb abstraction for writeback blocks") > > Signed-off-by: Marijn Suijten <marijn.suijten@xxxxxxxxxxxxxx> > > --- > > It seems like WB UBWC formats are not supported today. Because otherwise > ctx->mdp would be used for writeback. I guess we can add a ubwc member > similar to hw_sspp, when we do add the support for this. Hence this is, That seems preferable to me. SSPP does the same in patch 3/3, and I have been thinking to replace the dpu_mdss_cfg *catalog parameter in dpu_hw_sspp_init with just the ubwc cfg pointer. Likewise dpu_hw_ctl_init also takes the full dpu_mdss_cfg only to take out the mixers. - Marijn > Reviewed-by: Abhinav Kumar <quic_abhinavk@xxxxxxxxxxx>