On Mon, Apr 17, 2023 at 12:46:05PM +0200, Heiko Stübner wrote: > Hi Sascha, > > Am Montag, 17. April 2023, 11:42:15 CEST schrieb Sascha Hauer: > > During a suspend/resume cycle the VO power domain will be disabled and > > the VOP2 registers will reset to their default values. After that the > > cached register values will be out of sync and the read/modify/write > > operations we do on the window registers will result in bogus values > > written. Fix this by marking the regcache as dirty each time we disable > > the VOP2 and call regcache_sync() each time we enable it again. With > > this the VOP2 will show a picture after a suspend/resume cycle whereas > > without this the screen stays dark. > > > > Fixes: 604be85547ce4 ("drm/rockchip: Add VOP2 driver") > > Cc: stable@xxxxxxxxxxxxxxx > > Signed-off-by: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx> > > somehow we overlapped with this v2 and me applying the original one [0] > to drm-misc. With drm-misc being a shared tree there is also no way back. > > So if this v2 is better suited, could do a follow-up patch instead - on > top of your original one? Alright, just did that. You should find it in your inbox. Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |