On Thu, Apr 06, 2023 at 04:03:53PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@xxxxxxx>
>
> The Samsung DSIM IP block allows the inversion of the clock and
> data lanes.
>
> Add an optional property called 'lane-polarities' that describes the
> polarities of the MIPI DSI clock and data lanes.
>
> This property is useful for properly describing the hardware when the
> board designer decided to switch the polarities of the MIPI DSI
> clock and/or data lanes.
>
> Signed-off-by: Fabio Estevam <festevam@xxxxxxx>
> ---
> Changes since v1:
> - Rebased against drm-misc-next that has samsung,mipi-dsim.yaml.
>
> .../display/bridge/samsung,mipi-dsim.yaml | 29 +++++++++++++++++++
> 1 file changed, 29 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/display/bridge/samsung,mipi-dsim.yaml b/Documentation/devicetree/bindings/display/bridge/samsung,mipi-dsim.yaml
> index e841659e20cd..04eb440ade72 100644
> --- a/Documentation/devicetree/bindings/display/bridge/samsung,mipi-dsim.yaml
> +++ b/Documentation/devicetree/bindings/display/bridge/samsung,mipi-dsim.yaml
> @@ -105,6 +105,35 @@ properties:
> DSI output port node to the panel or the next bridge
> in the chain.
>
> + properties:
> + endpoint:
> + $ref: /schemas/graph.yaml#/$defs/endpoint-base
No, this should be video-interfaces.yaml since you use properties from
it.
> + unevaluatedProperties: false
> +
> + properties:
> + data-lanes:
> + oneOf:
> + - minItems: 1
> + maxItems: 4
> + uniqueItems: true
> + items:
> + enum: [ 1, 2, 3, 4 ]
The h/w really supports any combination of lanes to be used?
> + description:
> + See ../../media/video-interfaces.yaml for details.
> +
> + lane-polarities:
> + minItems: 1
> + maxItems: 5
> + items:
> + enum: [ 0, 1 ]
> + description:
> + See ../../media/video-interfaces.yaml for details.
> + The Samsung MIPI DSI IP requires that all the data lanes have
> + the same polarity.
Sounds like a constraint:
oneOf:
- items:
const: 0
- items:
const: 1
> +
> + dependencies:
> + lane-polarities: [data-lanes]
> +
> required:
> - clock-names
> - clocks
> --
> 2.34.1
>
