Applied. Thanks! On Sun, Apr 9, 2023 at 8:48 PM Quan, Evan <Evan.Quan@xxxxxxx> wrote: > > [AMD Official Use Only - General] > > Reviewed-by: Evan Quan <evan.quan@xxxxxxx> > > > -----Original Message----- > > From: Tom Rix <trix@xxxxxxxxxx> > > Sent: Saturday, April 1, 2023 12:41 AM > > To: Quan, Evan <Evan.Quan@xxxxxxx>; Deucher, Alexander > > <Alexander.Deucher@xxxxxxx>; Koenig, Christian > > <Christian.Koenig@xxxxxxx>; Pan, Xinhui <Xinhui.Pan@xxxxxxx>; > > airlied@xxxxxxxxx; daniel@xxxxxxxx; nathan@xxxxxxxxxx; > > ndesaulniers@xxxxxxxxxx; Zhang, Hawking <Hawking.Zhang@xxxxxxx>; > > Feng, Kenneth <Kenneth.Feng@xxxxxxx>; Lazar, Lijo > > <Lijo.Lazar@xxxxxxx>; Wang, Yang(Kevin) <KevinYang.Wang@xxxxxxx>; > > Huang, Tim <Tim.Huang@xxxxxxx>; andrealmeid@xxxxxxxxxx; Liu, Kun > > <Kun.Liu2@xxxxxxx>; Limonciello, Mario <Mario.Limonciello@xxxxxxx> > > Cc: amd-gfx@xxxxxxxxxxxxxxxxxxxxx; dri-devel@xxxxxxxxxxxxxxxxxxxxx; linux- > > kernel@xxxxxxxxxxxxxxx; llvm@xxxxxxxxxxxxxxx; Tom Rix <trix@xxxxxxxxxx> > > Subject: [PATCH] drm/amd/pm: remove unused num_of_active_display > > variable > > > > clang with W=1 reports > > drivers/gpu/drm/amd/amdgpu/../pm/swsmu/amdgpu_smu.c:1700:6: error: > > variable > > 'num_of_active_display' set but not used [-Werror,-Wunused-but-set- > > variable] > > int num_of_active_display = 0; > > ^ > > This variable is not used so remove it. > > > > Signed-off-by: Tom Rix <trix@xxxxxxxxxx> > > --- > > drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 7 ------- > > 1 file changed, 7 deletions(-) > > > > diff --git a/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c > > b/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c > > index b5d64749990e..f93f7a9ed631 100644 > > --- a/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c > > +++ b/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c > > @@ -1696,8 +1696,6 @@ static int smu_display_configuration_change(void > > *handle, > > const struct > > amd_pp_display_configuration *display_config) { > > struct smu_context *smu = handle; > > - int index = 0; > > - int num_of_active_display = 0; > > > > if (!smu->pm_enabled || !smu->adev->pm.dpm_enabled) > > return -EOPNOTSUPP; > > @@ -1708,11 +1706,6 @@ static int smu_display_configuration_change(void > > *handle, > > smu_set_min_dcef_deep_sleep(smu, > > display_config- > > >min_dcef_deep_sleep_set_clk / 100); > > > > - for (index = 0; index < display_config- > > >num_path_including_non_display; index++) { > > - if (display_config->displays[index].controller_id != 0) > > - num_of_active_display++; > > - } > > - > > return 0; > > } > > > > -- > > 2.27.0