Maíra Canal <mcanal@xxxxxxxxxx> writes: Hello Maíra, > On 4/6/23 08:11, Daniel Vetter wrote: >> On Thu, Apr 06, 2023 at 01:02:34PM +0200, Javier Martinez Canillas wrote: >>> This helper is just a wrapper that calls drm_connector_cleanup(), there's >>> no need to have another level of indirection. >>> >>> Signed-off-by: Javier Martinez Canillas <javierm@xxxxxxxxxx> >> >> On both patches: >> >> Reviewed-by: Daniel Vetter <daniel.vetter@xxxxxxxx> >> >> Aside, would be a nice cleanup to move vkms output stuff (crtc and >> connector) over to the drmm_ stuff. The plane already does that. > > I sent a patch [1] a while ago moving the CRTC to the drmm_ functions. > If you could take a look at it, it would be great. > > [1] https://lore.kernel.org/dri-devel/20230116205800.1266227-1-mcanal@xxxxxxxxxx/T/ > I've now reviewed both patches from your series and they look good to me. > Best Regards, > - Maíra Canal > -- Best regards, Javier Martinez Canillas Core Platforms Red Hat
