Thomas Zimmermann <tzimmermann@xxxxxxx> writes: > From: Daniel Vetter <daniel.vetter@xxxxxxxx> > > This one nukes all framebuffers, which is a bit much. In reality > gma500 is igpu and never shipped with anything discrete, so there should > not be any difference. > > v2: Unfortunately the framebuffer sits outside of the pci bars for > gma500, and so only using the pci helpers won't be enough. Otoh if we > only use non-pci helper, then we don't get the vga handling, and > subsequent refactoring to untangle these special cases won't work. > > It's not pretty, but the simplest fix (since gma500 really is the only > quirky pci driver like this we have) is to just have both calls. > > v4: > - fix Daniel's S-o-b address > I believe they want to have their Intel S-o-B as well. I know that dim complains but that's what usually happens with danvet's patches AFAIK. > Signed-off-by: Daniel Vetter <daniel.vetter@xxxxxxxx> > Cc: Patrik Jakobsson <patrik.r.jakobsson@xxxxxxxxx> > Cc: Thomas Zimmermann <tzimmermann@xxxxxxx> > Cc: Javier Martinez Canillas <javierm@xxxxxxxxxx> > --- Patch looks good to me. Although I wonder if should just be dropped in favour of yours patch since are now part of the same series? Reviewed-by: Javier Martinez Canillas <javierm@xxxxxxxxxx> -- Best regards, Javier Martinez Canillas Core Platforms Red Hat
