Re: [PATCH v2 0/2] Update the handling of the primary plane

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 03/24, Maíra Canal wrote:
> This patchset focus on the proper handling of the primary plane after the
> modifications introduced in commit bc0d7fdefec6 ("drm: vkms: Supports to the
> case where primary plane doesn't match the CRTC"). Before this commit, the
> composition was executed on top of the primary plane. Therefore, the primary
> plane needed to cover the entire CRTC and it needed to be visible. After commit
> bc0d7fdefec6, this is no longer necessary, as the composition is now executed on
> top of the CRTC. So, remove those restrictions to the primary plane.
> 
> This patchset increased the vkms IGT test coverage. The following tests are now
> passing:
> 
> - igt@kms_atomic_transition@plane-toggle-modeset-transition
> - igt@kms_atomic_transition@modeset-transition
> - igt@kms_atomic_transition@modeset-transition-fencing
> - igt@kms_atomic_transition@modeset-transition-nonblocking
> - igt@kms_atomic_transition@modeset-transition-nonblocking-fencing
> - igt@kms_universal_plane@disable-primary-vs-flip-pipe-a
> - igt@kms_universal_plane@universal-plane-pageflip-windowed-pipe-a
> - igt@kms_universal_plane@universal-plane-pipe-a-functional
> 
> Moreover, this patchset was tested with the vkms IGT testlist and all tests
> passed successfully.

Nice catch. Thanks!

This series is:

Reviewed-by: Melissa Wen <mwen@xxxxxxxxxx>

> 
> Best Regards,
> - Maíra Canal
> 
> v1 -> v2: https://lore.kernel.org/dri-devel/20230320195558.134768-1-mcanal@xxxxxxxxxx/T/
> 
> * Introduce a second patch to allow the primary plane to be positioned.
> 
> ---
> 
> Maíra Canal (2):
>   drm/vkms: remove the need for the primary plane to be visible
>   drm/vkms: allow the primary plane to be positioned
> 
>  drivers/gpu/drm/vkms/vkms_plane.c | 10 +---------
>  1 file changed, 1 insertion(+), 9 deletions(-)
> 
> -- 
> 2.39.2
> 

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux