On Mon, Apr 03, 2023 at 11:51:50AM +0200, Krzysztof Kozlowski wrote:
> On 03/04/2023 09:19, Julien Stephan wrote:
> > From: Phi-bang Nguyen <pnguyen@xxxxxxxxxxxx>
> >
> > This is a new driver that supports the MIPI CSI CD-PHY for mediatek
> > mt8365 soc
> >
> > Signed-off-by: Louis Kuo <louis.kuo@xxxxxxxxxxxx>
> > Signed-off-by: Phi-bang Nguyen <pnguyen@xxxxxxxxxxxx>
> > [Julien Stephan: use regmap]
> > [Julien Stephan: use GENMASK]
> > Co-developed-by: Julien Stephan <jstephan@xxxxxxxxxxxx>
> > Signed-off-by: Julien Stephan <jstephan@xxxxxxxxxxxx>
> > ---
> > .../bindings/phy/mediatek,csi-phy.yaml | 9 +-
> > MAINTAINERS | 1 +
> > drivers/phy/mediatek/Kconfig | 8 +
> > drivers/phy/mediatek/Makefile | 2 +
> > .../phy/mediatek/phy-mtk-mipi-csi-rx-reg.h | 435 ++++++++++++++++++
> > drivers/phy/mediatek/phy-mtk-mipi-csi.c | 392 ++++++++++++++++
> > 6 files changed, 845 insertions(+), 2 deletions(-)
> > create mode 100644 drivers/phy/mediatek/phy-mtk-mipi-csi-rx-reg.h
> > create mode 100644 drivers/phy/mediatek/phy-mtk-mipi-csi.c
> >
> > diff --git a/Documentation/devicetree/bindings/phy/mediatek,csi-phy.yaml b/Documentation/devicetree/bindings/phy/mediatek,csi-phy.yaml
> > index c026e43f35fd..ad4ba1d93a68 100644
> > --- a/Documentation/devicetree/bindings/phy/mediatek,csi-phy.yaml
> > +++ b/Documentation/devicetree/bindings/phy/mediatek,csi-phy.yaml
>
> NAK, bindings are always separate patches. It also does not make any
> sense - you just added it.
>
:( I messed up my rebase -i. This need to be moved and squashed with the
previous patch. I will fix it in v2. Thank you for reporting it
> > @@ -33,9 +33,14 @@ additionalProperties: false
> >
> > examples:
> > - |
> > - phy@10011800 {
> > + soc {
> > + #address-cells = <2>;
> > + #size-cells = <2>;
> > +
> > + phy@11c10000 {
> > compatible = "mediatek,mt8365-mipi-csi";
> > - reg = <0 0x10011800 0 0x60>;
> > + reg = <0 0x11c10000 0 0x4000>;
> > #phy-cells = <1>;
> > + };
> > };
>
>
>
> k_mipi_dphy_of_match[] = {
> > + {.compatible = "mediatek,mt8365-mipi-csi"},
> > + {},
> > +};
> > +MODULE_DEVICE_TABLE(of, mtk_mipi_dphy_of_match);
> > +
> > +static struct platform_driver mipi_dphy_pdrv = {
> > + .probe = mtk_mipi_dphy_probe,
> > + .remove = mtk_mipi_dphy_remove,
> > + .driver = {
> > + .name = "mtk-mipi-csi",
> > + .of_match_table = of_match_ptr(mtk_mipi_dphy_of_match),
>
> Drop of_match_ptr(). You should see W=1 warnings when compile testing.
>
I do not not see any warnings when trying to compile with W=1. Am I
missing something? I will drop it in v2 anyway
Best
Julien
>
> Best regards,
> Krzysztof
>
