Hello Hans, On Wed, 29 Mar 2023 13:16:22 +0200 Hans Verkuil <hverkuil-cisco@xxxxxxxxx> wrote: > Hi Luca, > > I finally found the time to test this series. It looks OK, except for this patch. Thank you very much for taking the time! > The list of supported formats really has to be the intersection of what the tegra > supports and what the sensor supports. > > Otherwise you would advertise pixelformats that cannot be used, and the application > would have no way of knowing that. As far as I understand, I think we should rather make this driver fully behave as an MC-centric device. It is already using MC quite successfully after all. Do you think this is correct? If you do, then I think the plan would be: - Add the V4L2_CAP_IO_MC flag - As the mbus_code in get_format appropriately - Leave the changes in this patch unmodified otherwise Best regards, Luca -- Luca Ceresoli, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
