On 03/04/2023 14:44, Fabio Estevam wrote: > From: Jagan Teki <jagan@xxxxxxxxxxxxxxxxxxxx> > > Samsung MIPI DSIM bridge can be found on Exynos and NXP's > i.MX8M Mini/Nano/Plus SoCs. > > Convert exynos_dsim.txt to yaml. > > Used the example node from latest Exynos SoC instead of > the one used in legacy exynos_dsim.txt. > > Signed-off-by: Jagan Teki <jagan@xxxxxxxxxxxxxxxxxxxx> > Signed-off-by: Fabio Estevam <festevam@xxxxxxx> > --- > Changes since v1: > - Added samsung,mipi-dsim.yaml entry to MAINTAINERS file (Jagan) > - Added Marek Szyprowski entry to the samsung,mipi-dsim.yaml maintainers section (Jagan) > - Mention that i.MX8M Plus is also supported (Marek) > - Remove endpoint@0 description as it only has one endpoint (Marek) Where is the changelog from original submission? How your v1 differs form it? Or did you just ignore all the feedback? > > .../display/bridge/samsung,mipi-dsim.yaml | 271 ++++++++++++++++++ > .../bindings/display/exynos/exynos_dsim.txt | 92 ------ > MAINTAINERS | 1 + > 3 files changed, 272 insertions(+), 92 deletions(-) > create mode 100644 Documentation/devicetree/bindings/display/bridge/samsung,mipi-dsim.yaml > delete mode 100644 Documentation/devicetree/bindings/display/exynos/exynos_dsim.txt > > diff --git a/Documentation/devicetree/bindings/display/bridge/samsung,mipi-dsim.yaml b/Documentation/devicetree/bindings/display/bridge/samsung,mipi-dsim.yaml > new file mode 100644 > index 000000000000..2698752dc6ed > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/bridge/samsung,mipi-dsim.yaml > @@ -0,0 +1,271 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/bridge/samsung,mipi-dsim.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Samsung MIPI DSIM bridge controller > + > +maintainers: > + - Inki Dae <inki.dae@xxxxxxxxxxx> > + - Jagan Teki <jagan@xxxxxxxxxxxxxxxxxxxx> > + > +description: | > + Samsung MIPI DSIM bridge controller can be found it on Exynos > + and i.MX8M Mini/Nano/Plus SoC's. > + > +properties: > + compatible: > + enum: > + - samsung,exynos3250-mipi-dsi > + - samsung,exynos4210-mipi-dsi > + - samsung,exynos5410-mipi-dsi > + - samsung,exynos5422-mipi-dsi > + - samsung,exynos5433-mipi-dsi > + - fsl,imx8mm-mipi-dsim > + - fsl,imx8mp-mipi-dsim > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + '#address-cells': > + const: 1 > + > + '#size-cells': > + const: 0 > + > + clocks: > + minItems: 2 > + maxItems: 5 > + > + clock-names: > + minItems: 2 > + maxItems: 5 > + > + phys: > + maxItems: 1 > + description: phandle to the phy module representing the DPHY OK, so you did ignore the feedback. NAK, go through the feedback and implement it. Best regards, Krzysztof
