Hi Thorsten, On 31/03/2023 11:39, Thorsten Leemhuis wrote: > On 30.03.23 20:13, Matthieu Baerts wrote: >> Since v6.3, checkpatch.pl now complains about the use of "Closes:" tags >> followed by a link [1]. It also complains if a "Reported-by:" tag is >> followed by a "Closes:" one [2]. >> >> As detailed in the first patch, this "Closes:" tag is used for a bit of >> time, mainly by DRM and MPTCP subsystems. It is used by some bug >> trackers to automate the closure of issues when a patch is accepted. >> It is even planned to use this tag with bugzilla.kernel.org [3]. >> >> The first patch updates the documentation to explain what is this >> "Closes:" tag and how/when to use it. The second patch modifies >> checkpatch.pl to stop complaining about it. >> >> The DRM maintainers and their mailing list have been added in Cc as they >> are probably interested by these two patches as well. >> >> [1] https://lore.kernel.org/all/3b036087d80b8c0e07a46a1dbaaf4ad0d018f8d5.1674217480.git.linux@xxxxxxxxxxxxx/ >> [2] https://lore.kernel.org/all/bb5dfd55ea2026303ab2296f4a6df3da7dd64006.1674217480.git.linux@xxxxxxxxxxxxx/ >> [3] https://lore.kernel.org/linux-doc/20230315181205.f3av7h6owqzzw64p@meerkat.local/ >> >> Signed-off-by: Matthieu Baerts <matthieu.baerts@xxxxxxxxxxxx> > > Maybe it's just me, but I think those changes do not make it clear > enough when to use Link: and when to use Closes. Find below an > alternative proposal how I'd do it for consideration that goes > 'all-in' for the sake of simplicity. Thank you for the new proposition. I like your approach of forcing people to use the "Closes:" tag, I didn't think it would have been OK. I will wait a bit before sending a v4 just to get more feedback about that. The good thing with this approach is that it makes things clear. The "Closes:" tag is then no longer an alternative to "Link:" but a different tag, e.g. to be used after "Reported-by" as you did in your patch. I guess as any warnings from checkpatch.pl, it needs to be interpreted, e.g. if multiple bugs are reported in the same report as Conor mentioned. Cheers, Matt -- Tessares | Belgium | Hybrid Access Solutions www.tessares.net
