On Thu, Mar 30, 2023 at 07:56:26PM +0530, Jagan Teki wrote: > On Thu, Mar 30, 2023 at 3:48 PM Francesco Dolcini <francesco@xxxxxxxxxx> wrote: > > > > From: Francesco Dolcini <francesco.dolcini@xxxxxxxxxxx> > > > > SN65DSI8[34] device supports burst video mode and non-burst video mode > > with sync events or with sync pulses packet transmission as described in > > the DSI specification. > > > > Add property to select the expected mode, this allows for example to > > select a mode that is compatible with the DSI host interface. > > > > Signed-off-by: Francesco Dolcini <francesco.dolcini@xxxxxxxxxxx> > > --- > > .../devicetree/bindings/display/bridge/ti,sn65dsi83.yaml | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml b/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml > > index 48a97bb3e2e0..ebee16726b02 100644 > > --- a/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml > > +++ b/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml > > @@ -35,6 +35,14 @@ properties: > > vcc-supply: > > description: A 1.8V power supply (see regulator/regulator.yaml). > > > > + dsi-video-mode: > > + description: | > > + 0 - burst-mode > > + 1 - non-burst with sync event > > + 2 - non-burst with sync pulse > > + $ref: /schemas/types.yaml#/definitions/uint32 > > + enum: [0, 1, 2] > > I'm thinking this can go to dsi common code since the video modes are > common across all controllers and make the core initialize the default > and update if any sink devices are willing to change the modes. Sound > like a big move but worth useful. Not sure I understood where do you want to move this. In any case this is something about the display side of the DSI video connection, with the bridge as a special case, not about the controller. To my understanding the controller is supposed to support all the modes. Francesco