On Thu, 26 Jan 2023 17:09:12 -0800, Douglas Anderson wrote:
> The DP AUX interrupt handling was a bit of a mess.
> * There were two functions (one for "native" transfers and one for
> "i2c" transfers) that were quite similar. It was hard to say how
> many of the differences between the two functions were on purpose
> and how many of them were just an accident of how they were coded.
> * Each function sometimes used "else if" to test for error bits and
> sometimes didn't and again it was hard to say if this was on purpose
> or just an accident.
> * The two functions wouldn't notice whether "unknown" bits were
> set. For instance, there seems to be a bit "DP_INTR_PLL_UNLOCKED"
> and if it was set there would be no indication.
> * The two functions wouldn't notice if more than one error was set.
>
> [...]
Applied, thanks!
[1/2] drm/msm/dp: Clean up handling of DP AUX interrupts
https://gitlab.freedesktop.org/lumag/msm/-/commit/9dd5895a5687
[2/2] drm/msm/dp: Return IRQ_NONE for unhandled interrupts
https://gitlab.freedesktop.org/lumag/msm/-/commit/f185c87fa119
Best regards,
--
Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
