Re: [PATCH 03/32] drm/amdkfd: prepare per-process debug enable and disable

Felix Kuehling <felix.kuehling@xxxxxxx> · Thu, 23 Mar 2023 16:08:03 -0400

Sorry, I think that was just a stray comment that I messed up while 
editing my response. You can ignore it.

Regards,
  Felix


Am 2023-03-23 um 15:12 schrieb Kim, Jonathan:
index c06ada0844ba..a2ac98d06e71 100644

--- a/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c
+++ b/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c
@@ -979,6 +979,14 @@ static int evict_process_queues_cpsch(struct
device_queue_manager *dqm,
             goto out;

     pdd = qpd_to_pdd(qpd);
+
+   /* The debugger creates processes that temporarily have not
acquired
+    * all VMs for all devices and has no VMs itself.
+    * Skip queue eviction on process eviction.
+    */
+   if (!pdd->drm_priv)
+           goto out;
+
This should be before qpd->
Sorry I didn't quite catch what you were saying here (did your comment get cutoff?).
Did you mean the pdd->drm_priv check needs to go before the if (qpd->evicted++ > 0) /* already evicted, do nothing */ check?

Thanks,

Jon







