Hi Alfredo, while I do agree with the patch content, there are missing: a patch description ... just a customary thing for a change like this but more importantly the Signed-off-by line . Heiko Am Dienstag, 14. März 2023, 20:15:32 CET schrieb Alfredo Cruz: > --- > drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c > index 03ca32cd2050..4bde2d354462 100644 > --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c > +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c > @@ -2680,6 +2680,8 @@ static int vop2_bind(struct device *dev, struct device *master, void *data) > vop2->len = resource_size(res); > > vop2->map = devm_regmap_init_mmio(dev, vop2->regs, &vop2_regmap_config); > + if (IS_ERR(vop2->map)) > + return PTR_ERR(vop2->map); > > ret = vop2_win_init(vop2); > if (ret) >