Quoting Maxime Ripard (2023-03-22 03:01:53) > Hi Stephen, > > On Tue, Mar 21, 2023 at 04:55:03PM -0700, Stephen Boyd wrote: > > Quoting Maxime Ripard (2022-11-04 06:17:17) > > > Hi, > > > > > > This is a follow-up to a previous series that was printing a warning > > > when a mux has a set_parent implementation but is missing > > > determine_rate(). > > > > > > The rationale is that set_parent() is very likely to be useful when > > > changing the rate, but it's determine_rate() that takes the parenting > > > decision. If we're missing it, then the current parent is always going > > > to be used, and thus set_parent() will not be used. The only exception > > > being a direct call to clk_set_parent(), but those are fairly rare > > > compared to clk_set_rate(). > > > > > > Stephen then asked to promote the warning to an error, and to fix up all > > > the muxes that are in that situation first. So here it is :) > > > > > > Let me know what you think, > > > > What's the plan here? Are you going to resend? > > It wasn't clear to me whether or not this was something that you wanted, > and I got some pushback on the drivers so I kind of forgot about it. > > If you do want it (and it looks like you do), I'll resend it. Let me read the whole series first. I was ignoring it because I was assuming it was going to be resent.
