Hi Ye,
Thank you for the patch.
On Wed, Mar 22, 2023 at 04:22:51PM +0800, ye.xingchen@xxxxxxxxxx wrote:
> From: Ye Xingchen <ye.xingchen@xxxxxxxxxx>
>
> Replace the open-code with dev_err_probe() to simplify the code.
>
> Signed-off-by: Ye Xingchen <ye.xingchen@xxxxxxxxxx>
Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> ---
> drivers/gpu/drm/bridge/simple-bridge.c | 8 +++-----
> 1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/simple-bridge.c b/drivers/gpu/drm/bridge/simple-bridge.c
> index 5ede3e111096..d85d9ee463b8 100644
> --- a/drivers/gpu/drm/bridge/simple-bridge.c
> +++ b/drivers/gpu/drm/bridge/simple-bridge.c
> @@ -202,11 +202,9 @@ static int simple_bridge_probe(struct platform_device *pdev)
>
> sbridge->enable = devm_gpiod_get_optional(&pdev->dev, "enable",
> GPIOD_OUT_LOW);
> - if (IS_ERR(sbridge->enable)) {
> - if (PTR_ERR(sbridge->enable) != -EPROBE_DEFER)
> - dev_err(&pdev->dev, "Unable to retrieve enable GPIO\n");
> - return PTR_ERR(sbridge->enable);
> - }
> + if (IS_ERR(sbridge->enable))
> + return dev_err_probe(&pdev->dev, PTR_ERR(sbridge->enable),
> + "Unable to retrieve enable GPIO\n");
>
> /* Register the bridge. */
> sbridge->bridge.funcs = &simple_bridge_bridge_funcs;
--
Regards,
Laurent Pinchart
