Hi Ye,
Thank you for the patch.
On Wed, Mar 22, 2023 at 04:21:33PM +0800, ye.xingchen@xxxxxxxxxx wrote:
> From: Ye Xingchen <ye.xingchen@xxxxxxxxxx>
>
> Replace the open-code with dev_err_probe() to simplify the code.
>
> Signed-off-by: Ye Xingchen <ye.xingchen@xxxxxxxxxx>
Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> ---
> drivers/gpu/drm/bridge/display-connector.c | 9 +++------
> 1 file changed, 3 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/display-connector.c b/drivers/gpu/drm/bridge/display-connector.c
> index fbb3e102c02f..56ae511367b1 100644
> --- a/drivers/gpu/drm/bridge/display-connector.c
> +++ b/drivers/gpu/drm/bridge/display-connector.c
> @@ -271,12 +271,9 @@ static int display_connector_probe(struct platform_device *pdev)
> type == DRM_MODE_CONNECTOR_DisplayPort) {
> conn->hpd_gpio = devm_gpiod_get_optional(&pdev->dev, "hpd",
> GPIOD_IN);
> - if (IS_ERR(conn->hpd_gpio)) {
> - if (PTR_ERR(conn->hpd_gpio) != -EPROBE_DEFER)
> - dev_err(&pdev->dev,
> - "Unable to retrieve HPD GPIO\n");
> - return PTR_ERR(conn->hpd_gpio);
> - }
> + if (IS_ERR(conn->hpd_gpio))
> + return dev_err_probe(&pdev->dev, PTR_ERR(conn->hpd_gpio),
> + "Unable to retrieve HPD GPIO\n");
>
> conn->hpd_irq = gpiod_to_irq(conn->hpd_gpio);
> } else {
--
Regards,
Laurent Pinchart
