On Fri, 17 Mar 2023, Liu Ying wrote: > Hi Lee, > > On Fri, 2023-03-17 at 08:17 +0000, Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > > > scripts/Makefile.build:252: drivers/gpu/drm/bridge/imx/Makefile: imx-ldb-helper.o is added to multiple modules: imx8qm-ldb imx8qxp-ldb > > > > Cc: Liu Ying <victor.liu@xxxxxxx> > > Cc: Andrzej Hajda <andrzej.hajda@xxxxxxxxx> > > Cc: Neil Armstrong <neil.armstrong@xxxxxxxxxx> > > Cc: Robert Foss <rfoss@xxxxxxxxxx> > > Cc: Laurent Pinchart <Laurent.pinchart@xxxxxxxxxxxxxxxx> > > Cc: Jonas Karlman <jonas@xxxxxxxxx> > > Cc: Jernej Skrabec <jernej.skrabec@xxxxxxxxx> > > Cc: David Airlie <airlied@xxxxxxxxx> > > Cc: Daniel Vetter <daniel@xxxxxxxx> > > Cc: Shawn Guo <shawnguo@xxxxxxxxxx> > > Cc: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx> > > Cc: Pengutronix Kernel Team <kernel@xxxxxxxxxxxxxx> > > Cc: Fabio Estevam <festevam@xxxxxxxxx> > > Cc: NXP Linux Team <linux-imx@xxxxxxx> > > Cc: dri-devel@xxxxxxxxxxxxxxxxxxxxx > > Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx > > Signed-off-by: Lee Jones <lee@xxxxxxxxxx> > > Thank you for the patch. > > > --- > > drivers/gpu/drm/bridge/imx/Kconfig | 7 +++++++ > > drivers/gpu/drm/bridge/imx/Makefile | 7 +++++-- > > drivers/gpu/drm/bridge/imx/imx-ldb-helper.c | 13 +++++++++++++ > > 3 files changed, 25 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/gpu/drm/bridge/imx/Kconfig b/drivers/gpu/drm/bridge/imx/Kconfig > > index 608f47f41bcd1..97018dcd078d0 100644 > > --- a/drivers/gpu/drm/bridge/imx/Kconfig > > +++ b/drivers/gpu/drm/bridge/imx/Kconfig > > @@ -1,10 +1,16 @@ > > if ARCH_MXC || COMPILE_TEST > > > > +config DRM_IMX8_LIB > > I would limit this to i.MX LVDS Display Bridge(LDB) library, so I > suggest to use DRM_IMX_LDB_LIB. > > > + tristate > > + help > > + Common helper functions used by some of the drivers below. > > Considering to use DRM_IMX_LDB_LIB, help message can be a bit more > specific to LDB drivers, like: > > Common helper functions used by i.MX LVDS display bridge drivers below. Thanks for the help. Leave it with me. -- Lee Jones [李琼斯]
