Thomas Zimmermann <tzimmermann@xxxxxxx> writes: [...] > @@ -91,36 +93,52 @@ static int drm_fbdev_fb_probe(struct drm_fb_helper *fb_helper, > > fb_helper->buffer = buffer; > fb_helper->fb = buffer->fb; > - fb = buffer->fb; > + > + screen_size = buffer->gem->size; [...] > - info->screen_size = sizes->surface_height * fb->pitches[0]; [...] I wonder if this change should be a separate patch? I know that it should be the same size but still feels like an unrelated change that deserves a different patch and description. [...] > - /* Set a default deferred I/O handler */ > + /* deferred I/O */ I would either have it as /* Generic fbdev deferred I/O handler */ or just remove the comment. I understand why you are removing the "default", since implies that drivers can change the handler and that's not the case here. But I think that just leaving the "deferred I/O" comment there doesn't say that much. Reviewed-by: Javier Martinez Canillas <javierm@xxxxxxxxxx> -- Best regards, Javier Martinez Canillas Core Platforms Red Hat
