On Tue, 14 Mar 2023 at 17:32, Javier Martinez Canillas
<javierm@xxxxxxxxxx> wrote:
>
> Hans de Goede <hdegoede@xxxxxxxxxx> writes:
>
> Hello Hans,
>
> > Commit 8633ef82f101 ("drivers/firmware: consolidate EFI framebuffer setup
> > for all arches") moved the sysfb_apply_efi_quirks() call in sysfb_init()
> > from before the [sysfb_]parse_mode() call to after it.
> > But sysfb_apply_efi_quirks() modifies the global screen_info struct which
> > [sysfb_]parse_mode() parses, so doing it later is too late.
> >
> > This has broken all DMI based quirks for correcting wrong firmware efifb
> > settings when simpledrm is used.
> >
>
> Indeed... sorry for missing this.
>
> > To fix this move the sysfb_apply_efi_quirks() call back to its old place
> > and split the new setup of the efifb_fwnode (which requires
> > the platform_device) into its own function and call that at
> > the place of the moved sysfb_apply_efi_quirks(pd) calls.
> >
> > Fixes: 8633ef82f101 ("drivers/firmware: consolidate EFI framebuffer setup for all arches")
> > Cc: stable@xxxxxxxxxxxxxxx
> > Cc: Javier Martinez Canillas <javierm@xxxxxxxxxx>
> > Cc: Thomas Zimmermann <tzimmermann@xxxxxxx>
> > Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx>
> > ---
>
> Reviewed-by: Javier Martinez Canillas <javierm@xxxxxxxxxx>
>
Thanks - I've queued these up now
