Hi, Alexandre: Alexandre Mergnat <amergnat@xxxxxxxxxxxx> 於 2023年3月15日 週三 下午5:36寫道: > > Le lun. 13 mars 2023 à 16:21, Chun-Kuang Hu <chunkuang.hu@xxxxxxxxxx> a écrit : > > > > > > > > + dpi->dpi_clk = devm_clk_get_optional(dev, "dpi"); > > > > For MT8365, DPI clock is not optional, so make sure that MT8365 DPI > > should have this clock. > > This should be check and notified at build time thanks to the > device-tree binding. Do you prefer this?: > #IF MT8365_SOC > dpi->dpi_clk = devm_clk_get(dev, "dpi"); Add one member in struct mtk_dpi_conf for dpi_clk. In mtk_dpi_of_ids[], add one item for mt8365 { .compatible = "mediatek,mt8365-dpi", .data = &mt8365_conf, }, Regards, Chun-Kuang. > > Regards, > Alex