Thomas Zimmermann <tzimmermann@xxxxxxx> writes: Hello Thomas, > Hi Javier > > Am 10.03.23 um 13:59 schrieb Javier Martinez Canillas: >> Christian Hergert reports that the driver doesn't enable the property and >> that leads to always doing a full plane update, even when the driver does >> support damage clipping for the primary plane. >> >> Don't enable it for the cursor plane, because its .atomic_update callback >> doesn't handle damage clips. >> >> Reported-by: Christian Hergert <chergert@xxxxxxxxxx> >> Signed-off-by: Javier Martinez Canillas <javierm@xxxxxxxxxx> >> --- >> >> drivers/gpu/drm/virtio/virtgpu_plane.c | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/drivers/gpu/drm/virtio/virtgpu_plane.c b/drivers/gpu/drm/virtio/virtgpu_plane.c >> index 4c09e313bebc..a2e045f3a000 100644 >> --- a/drivers/gpu/drm/virtio/virtgpu_plane.c >> +++ b/drivers/gpu/drm/virtio/virtgpu_plane.c >> @@ -390,5 +390,9 @@ struct drm_plane *virtio_gpu_plane_init(struct virtio_gpu_device *vgdev, > > virtio_gpu_plane_init() should really be two separate functions. But > withing the constrains of the current code > Agreed, I thought the same. I may post a follow-up patch once this lands. > Reviewed-by: Thomas Zimmermann <tzimmermann@xxxxxxx> > Thanks! -- Best regards, Javier Martinez Canillas Core Platforms Red Hat
